-
Notifications
You must be signed in to change notification settings - Fork 55
Helm values - GUI configuration #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_logic Added widgets and initial conversion logic
Helm values - Basic GUI configuration view
vivek-devtron
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a GUI configuration view for updating/configuring the app values through the GUI form. It's using the JSON schema to create a form that allows users to update different basic properties in values.yaml through GUI.
GUI form uses different widgets listed below,
Resolves devtron-labs/devtron#1868, resolves devtron-labs/devtron#1869, resolves devtron-labs/devtron#1886, resolves devtron-labs/devtron#1888
Type of change
How Has This Been Tested?
All tests have been performed manually. Updating the YAML will update the GUI if the field is present & vice versa. The following are a few cases,
Case # 1: Deploying a new chart - values JSON schema is present
Expected: It should deploy the chart with updated values YAML.
Case # 2: Deploying a new chart - values JSON schema is not present
Expected: It should display an empty state.
Case # 3: Updating deployed chart's values - values JSON schema is present
Expected: It should deploy the chart with updated values YAML.
Case # 4: Updating deployed chart's values - values JSON schema is not present
Expected: It should display an empty state.
Case # 5: Certain key/path is not present in YAML but present in values JSON schema (GUI form)
Expected: It should add the key/path in values.yaml and the updated value for the respective field.
Checklist: