Skip to content

Conversation

kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Jul 22, 2022

Description

Earlier we introduced Enforcer Caching on Dashboard List APIs which has improved the Dashboard load time but there are other areas that are also impacted by Enforcer.

fixes #2072

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Following Scenarios has been tested.

  • Verify user having "View Only" Permission for a specific app
  • Verify User having "Build & Deploy" Permission for a specific app
  • Verify User having "Admin" Permission for a specific app
  • Verify User having "Manager" Permission for a specific app
  • Verify User Having "Super Admin" Permission
  • Verify the Response time for list APIs
  • Verify Helm Apps

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kripanshdevtron kripanshdevtron added the Task Sub issue of an issue label Jul 22, 2022
@kripanshdevtron kripanshdevtron self-assigned this Jul 22, 2022
@kripanshdevtron kripanshdevtron marked this pull request as ready for review July 27, 2022 11:33
@nishant-d nishant-d merged commit bfc44ec into main Jul 27, 2022
@nishant-d nishant-d deleted the enforcer-cache-issue branch July 27, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Sub issue of an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforcer Caching for remaining APIs
2 participants