Skip to content

Conversation

kripanshdevtron
Copy link
Contributor

@kripanshdevtron kripanshdevtron commented Aug 18, 2022

Description

User Attributes Functionality is created. We would be using this functionality in guided onboarding for user metadata storage.

Fixes #2198

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • User Attributes created using self user token
  • User Attributes fetched using self user token
  • User Attributes Updated using self user token

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested it for all user roles
  • I have added all the required unit/api test cases

@kripanshdevtron kripanshdevtron marked this pull request as ready for review August 18, 2022 18:36
@kripanshdevtron kripanshdevtron self-assigned this Aug 18, 2022
@kripanshdevtron kripanshdevtron added the enhancement New feature or request label Aug 18, 2022
nishant-d
nishant-d previously approved these changes Aug 25, 2022
@gitguardian
Copy link

gitguardian bot commented Sep 3, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret f48266b scripts/devtron-reference-helm-charts/reference-chart_3-13-0/env-values.yaml View secret
2763127 Generic High Entropy Secret f48266b scripts/devtron-reference-helm-charts/reference-chart_3-13-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

nishant-d
nishant-d previously approved these changes Sep 3, 2022
@nishant-d nishant-d merged commit d76ccac into main Sep 3, 2022
@nishant-d nishant-d deleted the guided-onboarding-user-metadata branch September 3, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserAttributes Data Entity Creation
2 participants