Skip to content

Conversation

manish-agrawal-ai
Copy link
Contributor

@manish-agrawal-ai manish-agrawal-ai commented Aug 31, 2022

Description

Argocd module integration from devtron stack manager.

Fixes #2293

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring

How Has This Been Tested?

  1. fresh installation -> Base - after our release -> no modules come as installed (then create helm release, then install cicd, then create devtron-app and helm release, then install argo-cd, then create devtron-app and helm release)
  2. fresh installation -> Base + cicd -> cicd module should come as installed. then create devtron-app and helm release, then install argo-cd, then create devtron-app and helm release
  3. fresh installation -> Base + cicd + argo-cd-> cicd and argo-cd modules come as installed, then create devtron-app and helm release (before configuring gitops and after)
  4. fresh installation -> Base + argo-cd -> is it allowed? -> Pawan (drive from documentation)
  5. I have already installed 5.0 version of devtron.
    5.1) I installed full mode -> after upgrading to our release, both cicd and argo-cd modules should come as installed (infra and code)
    5.2) I installed ea_only mode and I had installed cicd from UI -> after upgrading to our release, both cicd and argo-cd modules should come as installed (infra and code)
    5.3) I installed ea_only mode -> after upgrading to our release, both infra should be hyperion and both cicd and argo-cd should come as not-installed
  6. I am enterprise user and on 0.5.0 version of devtron. now I am upgrading stack to 0.5.1 using pipeline -> both cicd and argo-cd modules should come as installed (infra and code)
  7. programatically server update
  8. think for security integration as well.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Contributor Author

@manish-agrawal-ai manish-agrawal-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment

@gitguardian
Copy link

gitguardian bot commented Sep 2, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret f310ce0 scripts/devtron-reference-helm-charts/reference-chart_3-13-0/env-values.yaml View secret
2763127 Generic High Entropy Secret f310ce0 scripts/devtron-reference-helm-charts/reference-chart_3-13-0/secrets-test-values.yaml View secret
141558 Generic High Entropy Secret f310ce0 scripts/devtron-reference-helm-charts/reference-chart_4-14-0/env-values.yaml View secret
2763127 Generic High Entropy Secret f310ce0 scripts/devtron-reference-helm-charts/reference-chart_4-14-0/secrets-test-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

nishant-d
nishant-d previously approved these changes Sep 4, 2022
@vikramdevtron vikramdevtron requested review from nishant-d and removed request for nishant-d September 4, 2022 08:25
@manish-agrawal-ai manish-agrawal-ai changed the title Gitops acd integration FEAT: Enabled argocd as integration with devtron for GitOps Sep 4, 2022
@manish-agrawal-ai manish-agrawal-ai merged commit 68be502 into main Sep 4, 2022
@manish-agrawal-ai manish-agrawal-ai deleted the gitops_acd_integration branch September 4, 2022 08:51
@manish-agrawal-ai manish-agrawal-ai restored the gitops_acd_integration branch September 4, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Argocd module as integration
3 participants