Skip to content

Conversation

Ash-exp
Copy link
Contributor

@Ash-exp Ash-exp commented Apr 8, 2024

Description

Migration changes for notification

Fixes #4725

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ash-exp Ash-exp changed the title Chore: migration support for notification db changes chore: migration support for notification db changes Apr 8, 2024
@Ash-exp Ash-exp merged commit c796e43 into main Apr 8, 2024
@Ash-exp Ash-exp deleted the feat-notification-migration branch April 8, 2024 13:19
Laeeqdev pushed a commit that referenced this pull request Apr 9, 2024
* migration support for notification db changes

* updated query with internal flag
Laeeqdev added a commit that referenced this pull request Apr 9, 2024
* duplicate workflow name bug resolved

* refactored code

* completed dev testing and code

* PR code review comments resolved

* resolved PR code review comments

* resolved PR code review comments final

* misc: Refactoring Pagerduty Issue Calculator script (#4856)

* Modifying pager duty python script

* Updated CODEOWNERS

---------

Co-authored-by: Prakarsh <[email protected]>

* feat: Add support for git hash in the app and app group overview section _revised (#4836)

* Revised the api for handelling the overview git commits part using CiArtifact table only

* Removed unnecessary comments

* optimized the loop and intialization

* used maps instead of slices

* removed unused comments

* modified the GetUniqueArtifactIds

* Removed error from util function

* renamed the function as generateArtifactIDCommitMap

* feat:MailMaster Plugin v1.0 (#4825)

* MailMaster Plugin v1.0

* Update 232_mailmaster.up.sql

Updated Variable Names

* Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql

* Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql

* 233_mailmaster.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>

* return nil,err on git material fetch error (#4857)

* removed code for gitops repo migration in devtron apps (#4838)

Co-authored-by: Vikram <[email protected]>

* fix: update argo app repo url in patch (#4876)

* fix: injected app-serveice dependency into DeployedApplicationEventProcessor service (#4875)

* fix: depandabot version upgrade (#4792)

* dependabot version upgrade

* dependabot version upgrade

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* argo assets deletion reverted

* syncing specifig chart (#4631)

* fix: use JoinCookie method (#4892)

* chore: Resource mapping refactoring (#4813)

* change sync

* vars

* refactor

* fix: use JoinCookie method (#4892)

* sql file merged

---------

Co-authored-by: adi6859 <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>

* fix: rbac fix in case of project in upper case (#4840)

* lower case rbac objects

* lower case

* lower

* chore: App Store refactoring v4 (#4647)

* removed registerInArgo multiple impls

* extracted app metrics code

* migrated envLevel app metrics code to new service

* chore: Removed unused jira and migration  integration (#4498)

* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <[email protected]>

* chore: App store dead code cleanup and restructuring  (#4497)

* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <[email protected]>

* chart ref refactoring

* removed infra metrics db calls

* moved app metrics repositories from /internal to /pkg

* moved: const and types to bean

* removed: unused const

* review comments

* migrated some methods from chartService to chartRefService

* added dt validation service interface

* minor refactoring

* moved validation method - 1

* wip

* removed redundant appMetrics req obj

* moved app metrics bindings  to wireset

* removed multiple dead code

* remove redundant dependency

* moved ChartGroup router and rest handler to respective folder

* stage 1

* gitOps refactoring

* moved gitClient code to a common wrapper service

* chore: AppStoreDeployment Install flow refactoring

* review changes

* wip

* fix for unsupported charts

* refactoring: App Store deployment services

* minor cleanup

* renamed remote package to git

* renamed gitOpsRemoteOpService If and impl

* migrated usages of gitService to gitOperationService

* shifted git service and all gitOps clients to pkg

* gitops repository usages refactor

* refactored gitOpsRepository usages

* gitlab client creation refactoring

* renamed util/ChartService

* reverted renaming changes

* reverted renaming changes

* reverted renaming changes

* wip

* wip

* removed typo

* changes

* changes

* chore: App store services refactoring  (#4596)

* chore: fixed test file

* chore: app store deployment services refactoring

* updated todo

* chore: dead code removal and app router & rest handler restructuring  (#4595) (#4608)

* prom code removal

* removed test suites

* chore: removed support for unused Prometheus and ArgoCd APIs

* chore: app router and rest handler restructuring

* removed redundant routings

* fixed: sub path

* Updated alias and added queries to AppList group router

---------

Co-authored-by: nishant <[email protected]>

* chore: sanity after ent sync

* added: todo comment

* added: todo comment

* chore: fixed gitops auto fix operations in upgrade helm charts

* added: nit pointer issue for argocd resource tree

* fixed: nil poniter issue for gitops in upgrade deployment

* chore: install Helm chart flow refactoring

* removed: comments

* chore: broken down AppStoreDeploymentService interface

* fix: install apps audit logs

* chore: update env name usgae

* chore: fixed main merge changes

* updated env var parsing

* moved attribute const to bean

* removed unused dependency injection

* chore: updated alias name

* updated: test file

* updated wire file

* fixed: nil pointer issue

* fixed: pg no row issue

* fixed: dependency injection

* fix: adapter data provider methods

* fix: data provider methods

* wip

* fix: helm app project link

* fixed panic on bulk trigger chart group event

* fixed gitops validations

* fixed delpoyment histroy status for manifest download

* App store chore refactoring v4 sync oss (#4778)

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

---------

Co-authored-by: Ash-exp <[email protected]>

---------

Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Shashwat Dadhich <[email protected]>

* fix: deprecate latest in app store app version (#4896)

* fix: deprecate latest flag from app_store application_version and increase varchar len for some columns

* fix: deprecate latest flag from app_store application_version and increase varchar len for some columns

* fix: remove digest column length update

* chore: migration support for notification db changes (#4906)

* migration support for notification db changes

* updated query with internal flag

* feat: Added the Devtron CI Trigger Plugin (#4902) (#4908)

* Added the Devtron CI Trigger Plugin

* Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql

* Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql

* Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql

* Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql

---------

Co-authored-by: Yashasvi17 <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
Co-authored-by: Rajeev Ranjan <[email protected]>
Co-authored-by: akshatsinha007 <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Vikram <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: Shashwat Dadhich <[email protected]>
Co-authored-by: iamayushm <[email protected]>
Co-authored-by: subhashish-devtron <[email protected]>
Co-authored-by: adi6859 <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Asutosh Das <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Kiran <[email protected]>
komalreddy3 pushed a commit that referenced this pull request May 28, 2024
* migration support for notification db changes

* updated query with internal flag
komalreddy3 pushed a commit that referenced this pull request May 28, 2024
* duplicate workflow name bug resolved

* refactored code

* completed dev testing and code

* PR code review comments resolved

* resolved PR code review comments

* resolved PR code review comments final

* misc: Refactoring Pagerduty Issue Calculator script (#4856)

* Modifying pager duty python script

* Updated CODEOWNERS

---------

Co-authored-by: Prakarsh <[email protected]>

* feat: Add support for git hash in the app and app group overview section _revised (#4836)

* Revised the api for handelling the overview git commits part using CiArtifact table only

* Removed unnecessary comments

* optimized the loop and intialization

* used maps instead of slices

* removed unused comments

* modified the GetUniqueArtifactIds

* Removed error from util function

* renamed the function as generateArtifactIDCommitMap

* feat:MailMaster Plugin v1.0 (#4825)

* MailMaster Plugin v1.0

* Update 232_mailmaster.up.sql

Updated Variable Names

* Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql

* Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql

* 233_mailmaster.up.sql

---------

Co-authored-by: Prakarsh <[email protected]>

* return nil,err on git material fetch error (#4857)

* removed code for gitops repo migration in devtron apps (#4838)

Co-authored-by: Vikram <[email protected]>

* fix: update argo app repo url in patch (#4876)

* fix: injected app-serveice dependency into DeployedApplicationEventProcessor service (#4875)

* fix: depandabot version upgrade (#4792)

* dependabot version upgrade

* dependabot version upgrade

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* argo assets deletion reverted

* syncing specifig chart (#4631)

* fix: use JoinCookie method (#4892)

* chore: Resource mapping refactoring (#4813)

* change sync

* vars

* refactor

* fix: use JoinCookie method (#4892)

* sql file merged

---------

Co-authored-by: adi6859 <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>

* fix: rbac fix in case of project in upper case (#4840)

* lower case rbac objects

* lower case

* lower

* chore: App Store refactoring v4 (#4647)

* removed registerInArgo multiple impls

* extracted app metrics code

* migrated envLevel app metrics code to new service

* chore: Removed unused jira and migration  integration (#4498)

* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <[email protected]>

* chore: App store dead code cleanup and restructuring  (#4497)

* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <[email protected]>

* chart ref refactoring

* removed infra metrics db calls

* moved app metrics repositories from /internal to /pkg

* moved: const and types to bean

* removed: unused const

* review comments

* migrated some methods from chartService to chartRefService

* added dt validation service interface

* minor refactoring

* moved validation method - 1

* wip

* removed redundant appMetrics req obj

* moved app metrics bindings  to wireset

* removed multiple dead code

* remove redundant dependency

* moved ChartGroup router and rest handler to respective folder

* stage 1

* gitOps refactoring

* moved gitClient code to a common wrapper service

* chore: AppStoreDeployment Install flow refactoring

* review changes

* wip

* fix for unsupported charts

* refactoring: App Store deployment services

* minor cleanup

* renamed remote package to git

* renamed gitOpsRemoteOpService If and impl

* migrated usages of gitService to gitOperationService

* shifted git service and all gitOps clients to pkg

* gitops repository usages refactor

* refactored gitOpsRepository usages

* gitlab client creation refactoring

* renamed util/ChartService

* reverted renaming changes

* reverted renaming changes

* reverted renaming changes

* wip

* wip

* removed typo

* changes

* changes

* chore: App store services refactoring  (#4596)

* chore: fixed test file

* chore: app store deployment services refactoring

* updated todo

* chore: dead code removal and app router & rest handler restructuring  (#4595) (#4608)

* prom code removal

* removed test suites

* chore: removed support for unused Prometheus and ArgoCd APIs

* chore: app router and rest handler restructuring

* removed redundant routings

* fixed: sub path

* Updated alias and added queries to AppList group router

---------

Co-authored-by: nishant <[email protected]>

* chore: sanity after ent sync

* added: todo comment

* added: todo comment

* chore: fixed gitops auto fix operations in upgrade helm charts

* added: nit pointer issue for argocd resource tree

* fixed: nil poniter issue for gitops in upgrade deployment

* chore: install Helm chart flow refactoring

* removed: comments

* chore: broken down AppStoreDeploymentService interface

* fix: install apps audit logs

* chore: update env name usgae

* chore: fixed main merge changes

* updated env var parsing

* moved attribute const to bean

* removed unused dependency injection

* chore: updated alias name

* updated: test file

* updated wire file

* fixed: nil pointer issue

* fixed: pg no row issue

* fixed: dependency injection

* fix: adapter data provider methods

* fix: data provider methods

* wip

* fix: helm app project link

* fixed panic on bulk trigger chart group event

* fixed gitops validations

* fixed delpoyment histroy status for manifest download

* App store chore refactoring v4 sync oss (#4778)

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

* code refactored

---------

Co-authored-by: Ash-exp <[email protected]>

---------

Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Shashwat Dadhich <[email protected]>

* fix: deprecate latest in app store app version (#4896)

* fix: deprecate latest flag from app_store application_version and increase varchar len for some columns

* fix: deprecate latest flag from app_store application_version and increase varchar len for some columns

* fix: remove digest column length update

* chore: migration support for notification db changes (#4906)

* migration support for notification db changes

* updated query with internal flag

* feat: Added the Devtron CI Trigger Plugin (#4902) (#4908)

* Added the Devtron CI Trigger Plugin

* Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql

* Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql

* Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql

* Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql

---------

Co-authored-by: Yashasvi17 <[email protected]>
Co-authored-by: Prakarsh <[email protected]>
Co-authored-by: Rajeev Ranjan <[email protected]>
Co-authored-by: akshatsinha007 <[email protected]>
Co-authored-by: Prakash <[email protected]>
Co-authored-by: Vikram <[email protected]>
Co-authored-by: Gireesh Naidu <[email protected]>
Co-authored-by: Shashwat Dadhich <[email protected]>
Co-authored-by: iamayushm <[email protected]>
Co-authored-by: subhashish-devtron <[email protected]>
Co-authored-by: adi6859 <[email protected]>
Co-authored-by: Shivam Nagar <[email protected]>
Co-authored-by: Asutosh Das <[email protected]>
Co-authored-by: kartik-579 <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: nishant <[email protected]>
Co-authored-by: Kiran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Notify if vulnerabilities are found in a build
3 participants