Skip to content

Conversation

Laeeqdev
Copy link
Contributor

@Laeeqdev Laeeqdev commented May 27, 2024

Description

In this we are removing some unnecessary environment variables which is not required by orchestrator
Fixes #5175

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

gitguardian bot commented May 27, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10190659 Triggered Generic High Entropy Secret 2f675bb wireNilChecker.env View secret
10190660 Triggered Generic Password 7090715 tests/integrationTesting/devtron-secret.yaml View secret
10190661 Triggered Generic Password 2f675bb wireNilChecker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Laeeqdev Laeeqdev requested a review from Shivam-nagar23 May 27, 2024 16:41
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Laeeqdev Laeeqdev merged commit ca21ac1 into main May 28, 2024
@Laeeqdev Laeeqdev deleted the removing-some-unnecessary-env branch May 28, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: remove unused envs
3 participants