Skip to content

misc: err handling for configmap access #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024
Merged

misc: err handling for configmap access #5938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c286c
fix: err handling for configmap access
gireesh-naidu Oct 1, 2024
2107a3a
Merge branch 'main' into telemetry-dashboard-event-panic-fixes
gireesh-naidu Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions client/telemetry/TelemetryEventClient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,10 @@ func (impl *TelemetryEventClientImpl) SendTelemetryDashboardAccessEvent() error
return err
}
cm, err := impl.K8sUtil.GetConfigMap(impl.aCDAuthConfig.ACDConfigMapNamespace, DevtronUniqueClientIdConfigMap, client)
if err != nil {
impl.logger.Errorw("DashboardAccessed EventForTelemetry,failed to get DevtronUniqueClientIdConfigMap", "error", err)
return err
}
datamap := cm.Data

accessEventValue, installEventKeyExists := datamap[UIEventKey]
Expand Down Expand Up @@ -667,6 +671,10 @@ func (impl *TelemetryEventClientImpl) SendTelemetryDashboardLoggedInEvent() erro
return err
}
cm, err := impl.K8sUtil.GetConfigMap(impl.aCDAuthConfig.ACDConfigMapNamespace, DevtronUniqueClientIdConfigMap, client)
if err != nil {
impl.logger.Errorw("DashboardLoggedIn EventForTelemetry,failed to get DevtronUniqueClientIdConfigMap", "error", err)
return err
}
datamap := cm.Data

accessEventValue, installEventKeyExists := datamap[UIEventKey]
Expand Down
Loading