Skip to content

fix: authenticator panic fix #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: authenticator panic fix #6131

merged 1 commit into from
Nov 26, 2024

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Nov 26, 2024 •
edited by vikramdevtron
Loading

Description

Fixes: https://github.com/devtron-labs/sprint-tasks/issues/1318

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kirandevtn kirandevtn changed the title fix: authenticator panic fix misc: authenticator panic fix Nov 26, 2024
@kartik-579 kartik-579 merged commit 6c786d5 into main Nov 26, 2024
12 of 16 checks passed
@kartik-579 kartik-579 deleted the authenticator-panic-fix branch November 26, 2024 11:47
@prakarsh-dt prakarsh-dt changed the title misc: authenticator panic fix fix: authenticator panic fix Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@nishant-d nishant-d Awaiting requested review from nishant-d

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@vivek-devtron vivek-devtron Awaiting requested review from vivek-devtron vivek-devtron is a code owner

Assignees
No one assigned
Labels
PR:Issue-verification-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartik-579 @vikramdevtron