Skip to content

fix: panic fixes #6411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025
Merged

fix: panic fixes #6411

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3625c5a
handle panic in GetCiPipelineById
prakash100198 Feb 18, 2025
8e1dc54
Merge branch 'develop' into panic-fixes-1
prakash100198 Feb 20, 2025
251cce8
Merge branch 'develop' into panic-fixes-1
prakash100198 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/pipeline/BuildPipelineConfigService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,8 @@ func (impl *CiPipelineConfigServiceImpl) GetCiPipelineById(pipelineId int) (ciPi
if err != nil && !util.IsErrNoRows(err) {
impl.logger.Errorw("error in fetching ci pipeline", "pipelineId", pipelineId, "err", err)
return nil, err
} else if util.IsErrNoRows(err) {
return nil, util.NewApiError(http.StatusNotFound, "ci pipeline not found", "ci pipeline not found ")
}
dockerArgs := make(map[string]string)
if len(pipeline.DockerArgs) > 0 {
Expand Down
Loading