Skip to content

simplified code via carbon #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

simplified code via carbon #454

wants to merge 2 commits into from
+14 −13

Conversation

kuafuRace
Copy link
Contributor

No description provided.

rcjsuen
rcjsuen reviewed Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kuafuRace, thank you for your pull request.

Could you clarify what is the advantage of using carbon over time in these cases?

@kuafuRace
Copy link
Contributor Author

It facilitates expansion and avoids some hard coding, such as time.Now().Format("2006-01-02")

@rcjsuen
Copy link
Collaborator

rcjsuen commented Aug 23, 2025

It facilitates expansion

I'm not very familiar the carbon library. Where can I learn more about this feature or what this exactly means?

@kuafuRace
Copy link
Contributor Author

kuafuRace commented Aug 23, 2025 •
edited
Loading

https://carbon.go-pkg.com/

@kuafuRace
Copy link
Contributor Author

Your current repository has already referenced the carbon library, we should maximize its value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcjsuen rcjsuen rcjsuen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuafuRace @rcjsuen