Skip to content

Conversation

vencakrecl
Copy link

@vencakrecl vencakrecl commented Jun 14, 2024

Summary

Pass options to FK because of \Doctrine\DBAL\Platforms\PostgreSQLPlatform::getAdvancedForeignKeyOptionsSQL

How to use

#[ORM\JoinColumn(name: 'customer_id', options: ['deferrable' => true, 'deferred' => true])]

@vencakrecl vencakrecl force-pushed the join-column-option branch 3 times, most recently from fa25d4b to cc2b82f Compare June 14, 2024 11:22
@derrabus
Copy link
Member

Thank you. Can you please add a functional test that actually creates such a foreign key?

@derrabus derrabus changed the base branch from 3.2.x to 3.3.x June 18, 2024 12:26
@derrabus derrabus changed the base branch from 3.3.x to 3.2.x June 18, 2024 12:27
@vencakrecl
Copy link
Author

vencakrecl commented Jun 18, 2024

@derrabus done, see f68b5e3

@vencakrecl vencakrecl force-pushed the join-column-option branch from e882b6d to f68b5e3 Compare June 18, 2024 12:54
@derrabus
Copy link
Member

No, your test compares the generated SQL. But that SQL still does not hit a database.

@vencakrecl
Copy link
Author

@derrabus If I understood, should I add the test \Doctrine\Tests\ORM\Functional\SchemaTool\PostgreSqlSchemaToolTest here?

@derrabus
Copy link
Member

Sounds about right to me. 🙂

@derrabus derrabus changed the base branch from 3.2.x to 3.3.x June 19, 2024 10:42
@vencakrecl vencakrecl force-pushed the join-column-option branch 2 times, most recently from 6fcc563 to 21f5d1b Compare July 7, 2024 20:25
@vencakrecl
Copy link
Author

vencakrecl commented Jul 7, 2024

@derrabus I added a functional test, see 6dfe0f3

@vencakrecl vencakrecl force-pushed the join-column-option branch from 21f5d1b to 6dfe0f3 Compare July 7, 2024 20:55
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Oct 15, 2024
@derrabus
Copy link
Member

Thanks, dear bot. This is on me. I'll try to conduct a review soon'ish. 🤞

@derrabus derrabus removed the Stale label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2025

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Feb 5, 2025
Copy link
Contributor

This pull request was closed due to inactivity.

@github-actions github-actions bot closed this Feb 15, 2025
@prochac
Copy link

prochac commented Feb 15, 2025

@derrabus ping? Would be a bit nicer if it was closed by a human, than by a bot due to review inactivity.
I wouldn't say a word if the ball is on the author's side when he doesn't fix review comments.

@greg0ire greg0ire reopened this Feb 18, 2025
@greg0ire greg0ire removed the Stale label Feb 18, 2025
Copy link
Contributor

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label May 20, 2025
@vencakrecl vencakrecl force-pushed the join-column-option branch 6 times, most recently from 9f3bad3 to 1b700bc Compare May 20, 2025 05:28
@github-actions github-actions bot removed the Stale label May 21, 2025
@vencakrecl vencakrecl force-pushed the join-column-option branch 4 times, most recently from 51e8ec5 to c6fa14e Compare June 15, 2025 07:52
@vencakrecl vencakrecl changed the base branch from 3.3.x to 3.4.x June 15, 2025 07:55
@vencakrecl vencakrecl force-pushed the join-column-option branch 2 times, most recently from 1ed8a52 to b093feb Compare June 15, 2025 07:58
@vencakrecl vencakrecl changed the title fix: pass join column options to FK feat: allow setting foreign deferrable key as IMMEDIATE or DEFERRABLE Jun 15, 2025
@vencakrecl vencakrecl force-pushed the join-column-option branch from b093feb to fcfcd9e Compare June 15, 2025 08:01
@vencakrecl
Copy link
Author

@derrabus I changed this according to this PR https://github.com/doctrine/orm/pull/10624/files

@vencakrecl vencakrecl force-pushed the join-column-option branch 3 times, most recently from 9a9347c to 31b63ea Compare June 15, 2025 08:07
@prochac

This comment was marked as abuse.

@greg0ire greg0ire changed the base branch from 3.4.x to 3.5.x June 16, 2025 20:27
@greg0ire greg0ire changed the base branch from 3.5.x to 3.6.x August 11, 2025 11:17
Copy link
Contributor

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants