-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: allow setting foreign deferrable key as IMMEDIATE or DEFERRABLE #11499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.6.x
Are you sure you want to change the base?
Conversation
fa25d4b
to
cc2b82f
Compare
Thank you. Can you please add a functional test that actually creates such a foreign key? |
e882b6d
to
f68b5e3
Compare
No, your test compares the generated SQL. But that SQL still does not hit a database. |
@derrabus If I understood, should I add the test \Doctrine\Tests\ORM\Functional\SchemaTool\PostgreSqlSchemaToolTest here? |
Sounds about right to me. 🙂 |
6fcc563
to
21f5d1b
Compare
21f5d1b
to
6dfe0f3
Compare
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Thanks, dear bot. This is on me. I'll try to conduct a review soon'ish. 🤞 |
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
This pull request was closed due to inactivity. |
@derrabus ping? Would be a bit nicer if it was closed by a human, than by a bot due to review inactivity. |
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
9f3bad3
to
1b700bc
Compare
51e8ec5
to
c6fa14e
Compare
1ed8a52
to
b093feb
Compare
b093feb
to
fcfcd9e
Compare
@derrabus I changed this according to this PR https://github.com/doctrine/orm/pull/10624/files |
9a9347c
to
31b63ea
Compare
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11404c2
to
4883035
Compare
Co-authored-by: Simon Podlipsky <[email protected]>
4883035
to
4e4c57c
Compare
Summary
Pass options to FK because of \Doctrine\DBAL\Platforms\PostgreSQLPlatform::getAdvancedForeignKeyOptionsSQL
How to use