Disable subquery collection-based ordering for SQL Server #12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix for issue #8580 where Microsoft SQL Server throws an exception if you include an ORDER BY clause in a subquery. In my case, I found this bug when using a Paginator and running the count command.
I attempted to devise unit testing methods, but couldn't find a reasonable approach. The countQuery function in the paginator is private and cannot be tested directly. SQL Server itself creates the exception, not Doctrine. Since there is no SQL server to spin up for testing that I can find, reproduction or testing is difficult!
I am running this fix on my servers and have encountered no problems, and it does resolve the issue. I am also willing to learn more if anyone can provide constructive guidance or criticism of my attempt.