-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Deprecate WithNuget
#2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate WithNuget
#2812
Conversation
Added .WithMsBuildArguments. Updated IntroNuGet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature cannot be supported for
dotnet run app.cs
(#2754)
I am fine with that. The fact that some of our users want to do something fancy does not mean that features used by other users should stop working.
complicates things like #2508
I agree. Since what you have provided in the docs is simpler to use and reliable I am fine with that direction. Thank you @timcassell !
The feature cannot be supported for
dotnet run app.cs
(#2754), and complicates things like #2508.Better to deprecate it for the next patch version, then remove it later in the next minor version.
The feature has been fully subsumed by the much more powerful MsBuildArguments (the only downside is user's csproj will have more lines).
Added
Job.WithMsBuildArguments
extension to simplify usage.