-
Notifications
You must be signed in to change notification settings - Fork 314
Port #3126 to release/6.0 #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Added test for downlevel connectivity warning * Correctly test bit flags for legacy SSL protocol warning * Corrected warning disablement/restore. (cherry picked from commit 198b906)
@edwardneal no need to make your own PR for this :) |
@edwardneal Ok, there's a good chance I bungled something up with the unit tests, since there were a couple conflicts. Would you be willing to take a peek at the unit test failures? I'm looking into the issue on my end, too. |
These failures look odd. I've pulled your branch locally, and these tests succeed. The diff looks reasonable to me. I don't think we can test non-TLS 1.2 connections in CI, so I'd revert the change to ConnectionTestParametersData.cs. If that passes, I'll replicate the change in main. |
@edwardneal, ok, let's try with the changes to the test matrix rolled back. I'm having a hard time confirming locally that it might work, I get the similar (same?) test failures when running main from before #3126 . I have no idea how this happened but the PR to main didn't have passing CI run. So even main is broken.... |
Thanks - once this is passing, I'll submit a PR correcting the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/6.0 #3127 +/- ##
===============================================
+ Coverage 72.66% 72.82% +0.16%
===============================================
Files 285 285
Lines 59162 59162
===============================================
+ Hits 42988 43085 +97
+ Misses 16174 16077 -97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ports #3126 to the release/6.0 branch. A couple merge conflicts were resolved. Please see the original PR for more information.