[release/9.4] Simplify Aspire CLI project name validation to only reject path separators #10832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…comprehensive tests Co-authored-by: mitchdenny <[email protected]>
…alidation regex Co-authored-by: mitchdenny <[email protected]>
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: mitchdenny <[email protected]>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
mitchdenny
approved these changes
Aug 5, 2025
JamesNK
approved these changes
Aug 6, 2025
danmoseley
approved these changes
Aug 11, 2025
|
@joperezr is the branch now open for 9.4.2 or did you want to merge this when its time? |
|
It is. merging. |
This was referenced Sep 3, 2025
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10714 to release/9.4
/cc @mitchdenny @copilot
Customer Impact
Validation logic for
aspire newproject name was too restrictive. This change loosens it so that it only blocks using path separators and relies ondotnet newto fail out when its rules aren't met. We block path separators because there are some specific corner cases there wheredotnet newwill acceptnot\a\valid\nameon Linux - but the app host will fail to run.Testing
Manual testing. Added test coverage
Risk
Low.
Regression?