-
Notifications
You must be signed in to change notification settings - Fork 687
[release/9.4] serve blazor.web.js from wwwroot #10990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transitions the Aspire Dashboard's blazor.web.js file from being served as an embedded resource to being served from the wwwroot directory as a static file. This change simplifies the file serving mechanism by removing custom endpoint mapping and embedded file provider infrastructure.
- Removes custom endpoint mapping for blazor.web.js that used embedded file providers
- Updates the script reference in App.razor to use the standard framework path
- Removes embedded resource configuration and related package dependencies
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/Aspire.Dashboard/DashboardWebApplication.cs | Removes call to MapDashboardBlazor() method |
src/Aspire.Dashboard/DashboardEndpointsBuilder.cs | Removes entire MapDashboardBlazor() method and related imports |
src/Aspire.Dashboard/Components/App.razor | Updates script src from custom path to standard framework path |
src/Aspire.Dashboard/Aspire.Dashboard.csproj | Removes embedded resource configuration and file provider package reference |
eng/Versions.props | Removes version property for embedded file provider package |
Directory.Packages.props | Removes package version entry for embedded file provider |
Customer Impact
At least 3 people have reported seeing this error when running the dashboard:
Unsure exactly what is causing the failure. Only some people are impacted. All reports are from MS folks?
We're fixing by switching to server the file from disk instead of using embedded file.
Testing
Manual. I launched the dashboard with the change to check the script file is available and the dashboard loads.
Risk
Low. Although it's critical that the dashboard loads this file, the delivery option (file on disk) is used for all other files. It's also easy to check whether it works or not.
Regression?
Yes. The dashboard worked consistently in 9.3, but in 9.4 there is this occasional error.