Skip to content

Adding public API test coverage for Aspire.Hosting.Nats #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 24, 2024
Merged

Adding public API test coverage for Aspire.Hosting.Nats #5129

merged 13 commits into from
Aug 24, 2024

Conversation

Zombach
Copy link
Contributor

@Zombach Zombach commented Jul 31, 2024 •
edited
Loading

Initial issues #2649
Issues Check List: Validate arguments of public methods

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 31, 2024
@Zombach Zombach mentioned this pull request Jul 31, 2024
Closed
56 tasks
@radical radical mentioned this pull request Aug 6, 2024
Closed
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Aug 6, 2024
@build-analysis build-analysis bot mentioned this pull request Aug 6, 2024
Open
3 tasks
@mitchdenny
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny enabled auto-merge (squash) August 21, 2024 04:31
@build-analysis build-analysis bot mentioned this pull request Aug 21, 2024
Closed
@mitchdenny mitchdenny merged commit 82660e3 into dotnet:main Aug 24, 2024
11 checks passed
@Zombach Zombach deleted the zombach/validate-arguments-of-public-methods#aspire-hosting-nats branch August 24, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member testing ☑️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zombach @mitchdenny @radical