Skip to content

Fix issue where replacement text is not getting evaluated when pack #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Fix issue where replacement text is not getting evaluated when pack #5411

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
862b5c6
Fix issue where replacement text is not getting evaluated when pack
joperezr Aug 23, 2024
f16e6cf
Do not depend on Restore target and instead copy to obj directory
joperezr Aug 23, 2024
911a69e
Include recursive dir
joperezr Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions eng/dcppack/Common.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,17 @@

<Target Name="Build" />

<Target Name="GetDCPBinaryLocation" Returns="$(DCPBinariesLocation)" DependsOnTargets="Restore">
<Target Name="_CopyDCPBinaryToIntermediateDir" AfterTargets="Build">
<ItemGroup>
<_DcpFilesToCopy Include="$(NuGetPackageRoot)microsoft.developercontrolplane.$(DcpPlatform)/$(MicrosoftDeveloperControlPlanedarwinamd64PackageVersion)\tools\**\*" />
</ItemGroup>

<Copy SourceFiles="@(_DcpFilesToCopy)" DestinationFolder="$(IntermediateOutputPath)\tools\%(RecursiveDir)" />
</Target>

<Target Name="GetDCPBinaryLocation" Returns="$(DCPBinariesLocation)">
<PropertyGroup>
<DCPBinariesLocation>$(NuGetPackageRoot)microsoft.developercontrolplane.$(DcpPlatform)/$(MicrosoftDeveloperControlPlanedarwinamd64PackageVersion)/tools</DCPBinariesLocation>
<DCPBinariesLocation>$(IntermediateOutputPath)/tools</DCPBinariesLocation>
</PropertyGroup>
</Target>

Expand Down