[ci] Internal build: build packages, and workload nugets only once #5417
Conversation
ghost
added
the
area-integrations
radical
added
area-engineering-systems
radical
force-pushed
the
internal-build-pack
branch
from
7887a4b to
f0f5031
Compare
.. installing the workload for testing.
radical
force-pushed
the
internal-build-pack
branch
from
23f3acf to
25294c2
Compare
|
Validation build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2527148&view=results . |
There was a problem hiding this comment.
Changes look good to me, thanks for cleaning this up @radical! One thing that I still feel a bit nervous about is the step for installing the workload to the separate dotnet-install in the artifacts dir for testing. Main worry is that: A) we run that after the non-helix tests have passed, so potentially rebuilding something that was already tested, and B) we also build this after signing packages, which might potentially re-build things unintentionally and not sign them.
| - script: ${{ parameters.buildScript }} | ||
| -restore -build | ||
| -pack | ||
| -sign $(_SignArgs) |
There was a problem hiding this comment.
NIT: Do we need to sign here? Can't we just keep the -sign param on the workloads build and have that sign everything?
This ensures that for the internal pipeline the tests are run against the final packages produced, instead of building packages twice - once for testing, and then for publishing.
Fixes #5404
Microsoft Reviewers: Open in CodeFlow