Skip to content

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Aug 28, 2024

Description

There was a breaking change between 2.27 and 2.28 - MongoDB.Driver added an assembly strong name.

We can now remove our NoWarn workarounds for MongoDB. Except Aspire.MongoDB.Driver still needs the NoWarn for 2 the health check and DiagnosticSource packages.

Fixes #5427

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

There was a breaking change between 2.27 and 2.28 - MongoDB.Driver added an assembly strong name.

We can now remove our NoWarn workarounds for MongoDB. Except Aspire.MongoDB.Driver still needs the NoWarn for 2 the health check and DiagnosticSource packages.
@eerhardt eerhardt requested a review from joperezr August 28, 2024 21:34
@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 28, 2024
@eerhardt
Copy link
Member Author

/backport to release/8.2

Copy link
Contributor

Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10604786056

@eerhardt eerhardt enabled auto-merge (squash) August 28, 2024 22:24
@eerhardt eerhardt merged commit 1d33f4b into dotnet:main Aug 29, 2024
11 checks passed
@eerhardt eerhardt deleted the UpdateMongoDB branch August 29, 2024 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version mismatch in Aspire.MongoDB.Driver
2 participants