Skip to content

Conversation

HofmeisterAn
Copy link
Contributor

@HofmeisterAn HofmeisterAn commented Sep 4, 2024

Description

Hi 👋 the PR updates Testcontainers to the latest version 3.10.0. This version includes a fix for the regression/changes made in the latest MSSQL Docker image (microsoft/mssql-docker#892). The recently added workaround (#5057, #5058) is no longer necessary.

Fixes #5057

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 4, 2024
@eerhardt eerhardt requested review from radical and eerhardt September 4, 2024 16:55
@radical
Copy link
Member

radical commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical enabled auto-merge (squash) September 4, 2024 20:58
@radical radical merged commit 66e77d8 into dotnet:main Sep 4, 2024
11 checks passed
@radical
Copy link
Member

radical commented Sep 4, 2024

@HofmeisterAn thank you for your contribution!

@HofmeisterAn HofmeisterAn deleted the feature/bump-testcontainers-version branch September 5, 2024 01:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing SqlServer, and SqlClient tests
3 participants