Initial integration of codespace URL rewriting logic into hosting. #6183
Conversation
| { | ||
| var uri = new Uri(originalUrlSnapshot.Url); | ||
|
|
||
| if (!originalUrlSnapshot.IsInternal && (uri.Scheme == "http" || uri.Scheme == "https") && uri.Host == "localhost") |
There was a problem hiding this comment.
Honestly I don't know what `IsInternal' really means - do you?
As for only exposing http and https schemed endpoints - from what I could tell that is the only option it supported. It doesn't seem to support anything other than HTTP.
There was a problem hiding this comment.
Honestly I don't know what `IsInternal' really means - do you?
No
| await Task.Delay(5000, stoppingToken).ConfigureAwait(false); | ||
| } while (!stoppingToken.IsCancellationRequested); |
There was a problem hiding this comment.
What are you doing here? If WatchAsync errors then won't it throw an error right out of this method? Also, there should be a log message if there was an error and you need to recover.
Add a test that covers this situation to verify it works.
|
I assume this is also post 9.0 |
davidfowl
added
the
NO-MERGE
Co-authored-by: James Newton-King <[email protected]>
I think so. This change is about the app host changes required to support codespaces better. But there are still some gotchas around the codespace devcontainer itself which I don't think are fully fleshed out. For example you need a devcontainer which supports Docker-in-Docker (ideally) which the default universal one does. But then you want to install the C# DevKit. I don't know if we've got options to streamline this experience for customers. |
|
One option would be to have a GitHub template with the DevContainer pre-configured with the right decontainer file and the recommended VSCode extensions and then the workflow would be that people create their repo based on that template, and then do dotnet new themselves. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| var gitHubCodespacesPortForwardingDomain = GetRequiredCodespacesConfigurationValue(GitHubCodespacesPortForwardingDomain); | ||
| var codespaceName = GetRequiredCodespacesConfigurationValue(CodespaceNameEnvironmentVariable); | ||
|
|
||
| do |
There was a problem hiding this comment.
Maybe add a comment that this runs for the lifetime of the host so it can react to resources as they start and new resources being added?
Co-authored-by: James Newton-King <[email protected]>
mitchdenny
removed
the
NO-MERGE
github-actions
bot
added
the
area-codeflow
Description
Adds support for GitHub Codespaces by automatically rewriting the URLs in the dashboard to point to the GitHub Codespaces proxied events.
Fixes #1178
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow