Improve trace application order on traces page #6261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The traces page shows a summary of info about it's spans apps . Spans are grouped by app, and then the apps are ordered by its earliest span.
The problem with this is span start dates can be out of order. For example, the start time reported by a .NET app and a browser app could be slightly off, causing a child browser app span to be earlier than its parent server span.
This PR changes the ordering logic so a child can't be ordered before its parent. There are performance improvements that could be made to here, but the old logic wasn't optimized either. Only runs for traces than are rendered to the screen which is limited by virtualization.
Low priority. Post 9.0
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow