Add ResourceExtensions.HasAnnotation methods #6357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new methods:
ResourceExtensions.HasAnnoationOfType<T>
ResourceExtensions.HasAnnotationIncludingAncestorsOfType<T>
Also modify
TryGetAnnotationOfType
andTryGetAnnotationsIncludingAncestorsOfType
to reduce allocations and remove stack-based recursion.Expand test coverage.
Some XML doc tweaks.
Would be helpful in #6209, where
TryGet*
is used and theout
param discarded.Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow