Add SchedulerHostAddress to DaprSidecarOptions #6478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I enhanced DaprSidecarOptions by adding the SchedulerHostAddress property. This will allow the developer to specify the host address of the Dapr scheduler service if not running on localhost (for example, if developing using Docker Compose, the scheduler service will be running on a different host). I enhanced the DaprDistributedApplicationLifecycleHook to pass the --scheduler-host-address parameter to the Dapr sidecar if the DaprSidecarOptions.SchedulerHostAddress property is specified. Resolves dotnet#6477
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
|
Did you test this PR? |
|
@davidfowl Yes, I did. Are you just asking for verification, or did you see a problem? I didn't see any unit tests for builder.AddExecutable("authorization-service", "../../../target/debug/authorization-service",
"../services/authorization")
.WithDaprSidecar(new DaprSidecarOptions
{
AppId = "authorization-service",
AppPort = 8000,
PlacementHostAddress = "placement:50006",
SchedulerHostAddress = "scheduler:50007"
})
.WithHttpEndpoint(8000, isProxied: false);Here's the Dapr sidecar logs where you can see it's picking up the value of |
We don't have test automation setup which makes it difficult to take any changes to the dapr integration currently. The substitute so far has been the playground example and manual verification. cc @philliphoff |
Understood. Is there anything else that I can do to move this forward? Unfortunately, this flag is going to be important for Dapr integration for anyone using Aspire with Dapr 1.14.x and not running with the basic setup (the scheduler service was introduced in the 1.14.0 release). Without it, the Dapr sidecar will continually throw errors. It might be a good idea to future-proof the Dapr integration to expose a generic |
@mfcollins3 That's a good idea, though I'd make that a separate PR. |
philliphoff
approved these changes
Nov 1, 2024
github-actions
bot
added
the
needs-area-label
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I enhanced DaprSidecarOptions by adding the SchedulerHostAddress property. This will allow the developer to specify the host address of the Dapr scheduler service if not running on localhost (for example, if developing using Docker Compose, the scheduler service will be running on a different host).
I enhanced the DaprDistributedApplicationLifecycleHook to pass the --scheduler-host-address parameter to the Dapr sidecar if the DaprSidecarOptions.SchedulerHostAddress property is specified.
Fixes #6477
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow