Skip to content

Use rc.2 branding on EF Npgsql integration #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Use rc.2 branding on EF Npgsql integration #6537

merged 1 commit into from
Oct 28, 2024

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Oct 28, 2024 •
edited
Loading

Description

Having EF NpgSql integration produce RC.2 branded prerelease in order to not downgrade from rc1 version during GA release.

cc: @eerhardt

Fixes #6492

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@joperezr joperezr requested a review from eerhardt October 28, 2024 20:59
eerhardt
eerhardt reviewed Oct 28, 2024
View reviewed changes
eng/Versions.props
<PreReleaseVersionLabel>preview.5</PreReleaseVersionLabel>
<!-- Aspire.Npgsql.EntityFrameworkCore.PostgreSQL will ship right after our November release, but it has already shipped as rc.1 so
we can't 'downgrade' it to preview.5. We will ship it as rc.2 in November and will mark it stable once EF Npgsql dependency ships stable. -->
<PrereleaseVersionLabel Condition="'$(MSBuildProjectName)' == 'Aspire.Npgsql.EntityFrameworkCore.PostgreSQL'">rc.2</PrereleaseVersionLabel>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would be in the Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.csproj.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I thought about it too but in this case I wanted to reduce the risk of properties getting overridden at the wrong time so to de-risk I opted for setting this at the exact same time as it would've been set before. Given this is a one-time change that will only ever be done in this branch, I think doing this is ok. That said, let me know if you have a strong preference on me moving things around.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. But we should really fix our build logic to be "right" so individual libraries can choose their versions independently.

@joperezr
Copy link
Member Author

Merging to get the release ready given the ongoing issues with CI builds.

@joperezr joperezr merged commit 3c42b10 into dotnet:release/9.0 Oct 28, 2024
3 checks passed
@joperezr joperezr mentioned this pull request Nov 1, 2024
Closed
joperezr added a commit to joperezr/aspire that referenced this pull request Nov 13, 2024
@joperezr
Merged PR 44502: Merge branch release/9.0 into internal/release/9.0
9081fdc 
#### AI description  (iteration 1)
#### PR Classification
Code update for version management and package dependencies.

#### PR Summary
This pull request updates version management and package dependencies to align with the upcoming release.
- Updated `PrereleaseVersionLabel` for `Aspire.Npgsql.EntityFrameworkCore.PostgreSQL` in `/eng/Versions.props`.
- Updated package versions for `Microsoft.Azure.Cosmos`, `NATS.Net`, and `Azure.Identity` in `/Directory.Packages.props`.

Related work items: dotnet#6530, dotnet#6537
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Mar 10, 2025
@joperezr joperezr deleted the UseRC2branding branch April 1, 2025 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joperezr @eerhardt