Skip to content

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Nov 14, 2024

Description

Seems like PackageValidation against a baseline version wasn't really working due to property import order (luckily we didn't introduce breaking changes). This PR enables it back and makes sure that the build fails if we make a change that breaks compatibility against our 9.0.0 package. This change also disables this baseline validation for packages that haven't shipped stable yet. Finally, I'm also moving us to use the GA SDK as part of this change.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@joperezr joperezr removed the request for review from sebastienros November 14, 2024 17:32
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to getting onto GA bits.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @joperezr!

@joperezr joperezr merged commit 6be7743 into dotnet:main Nov 18, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@joperezr joperezr deleted the PackageValidation branch April 1, 2025 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants