Refactor Bicep parameter usage #6683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
approved these changes
Nov 18, 2024
- Ensure any "known" parameters used by the infrastructure are in the Aspire AzureBicepResource's Parameter list - Remove unnecessary duplicate parameter manipulation
eerhardt
force-pushed
the
ParameterRefactor
branch
from
380cd2c to
9ac640f
Compare
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Nov 22, 2024
With Refactor Bicep parameter usage (dotnet#6683), we changed when "well-known" parameters were added to the AzureBicepResource. Instead of adding them up front in 2 places, we add them during bicep generation (i.e. ConfigureInfrastructure) and then sync the bicep parameters back to Aspire's AzureBicepResource.Parameters. This broke Azure Provisioning because it is looking for well known parameters before GetBicepTemplateFile is called. It needs to populate the well-known parameters after. The fix is to move the calls around so PopulateWellKnownParameters is called after GetBicepTemplateFile.
eerhardt
added a commit
that referenced
this pull request
Nov 25, 2024
With Refactor Bicep parameter usage (#6683), we changed when "well-known" parameters were added to the AzureBicepResource. Instead of adding them up front in 2 places, we add them during bicep generation (i.e. ConfigureInfrastructure) and then sync the bicep parameters back to Aspire's AzureBicepResource.Parameters. This broke Azure Provisioning because it is looking for well known parameters before GetBicepTemplateFile is called. It needs to populate the well-known parameters after. The fix is to move the calls around so PopulateWellKnownParameters is called after GetBicepTemplateFile.
github-actions
bot
added
the
area-app-model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Microsoft Reviewers: Open in CodeFlow