Skip to content

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Nov 18, 2024

This will allow us to ship Aspire.Npgsql.EntityFrameworkCore.PostgreSQL as stable 9.0.0. This should be backported to release/9.0.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the following as part of this change:

<!-- We need to ingest the stable version of EF npgsql in order for us to produce stable bits. -->
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>

Also update Npgsql DependencyInjection and OpenTelemetry to latest version, since these are referenced by the EF package.
@eerhardt
Copy link
Member Author

Can we also remove the following as part of this change:

<!-- We need to ingest the stable version of EF npgsql in order for us to produce stable bits. -->
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>

Good call. Removed.

@eerhardt
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11903378396

Copy link
Contributor

@eerhardt backporting to release/9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update Npgsql EF Core integration to latest versions
Applying: Remove SuppressFinalPackageVersion so it ships stable
Using index info to reconstruct a base tree...
M	Directory.Packages.props
Falling back to patching base and 3-way merge...
Auto-merging Directory.Packages.props
CONFLICT (content): Merge conflict in Directory.Packages.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0002 Remove SuppressFinalPackageVersion so it ships stable
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@eerhardt an error occurred while backporting to release/9.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@eerhardt eerhardt merged commit 18e1f59 into dotnet:main Nov 19, 2024
9 checks passed
@eerhardt eerhardt deleted the UpdateNpgsql9 branch November 19, 2024 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants