Skip to content

Conversation

danmoseley
Copy link
Member

Description

Update cgmanifest.json. Where I saw we had inconsistent versions, I updated the templates to latest -- @DamianEdwards let me know if this is in fact not appropriate.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • [x ] Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • [ x] No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • [x ] No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • [x ] No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • eng/Versions.props: Language not supported
  • src/Aspire.ProjectTemplates/cgmanifest.json: Language not supported
  • src/Aspire.ProjectTemplates/templates/aspire-starter/8.2/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported
  • src/Aspire.ProjectTemplates/templates/aspire-starter/9.0/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported
  • src/Aspire.ProjectTemplates/templates/aspire-starter/9.1/Aspire-StarterApplication.1.Tests/Aspire-StarterApplication.1.Tests.csproj: Language not supported

@danmoseley
Copy link
Member Author

also does the build automatically check the template projects succcessfully restore or do I do that manually?

<PackageReference Include="coverlet.collector" Version="6.0.2" Condition=" $(TestFramework) == 'xUnit.net' " />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" Condition=" $(TestFramework) != 'MSTest' " />
<PackageReference Include="MSTest" Version="3.4.3" Condition=" $(TestFramework) == 'MSTest' " />
<PackageReference Include="MSTest" Version="3.6.1" Condition=" $(TestFramework) == 'MSTest' " />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the unsupported template (8.2), we don't update these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to delete the 8.x templates yet?

@danmoseley
Copy link
Member Author

OK I think good now

@danmoseley
Copy link
Member Author

As discussed offline, this is guaranteed to get out of date/wrong. But for a moment, it is not

Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we have a plan to automate this somehow, at least failing when it gets out o date?

@danmoseley
Copy link
Member Author

No, we don't. Thread continues on that

@danmoseley danmoseley merged commit c2c5403 into dotnet:main Feb 11, 2025
70 checks passed
@danmoseley danmoseley deleted the cgmanifest branch February 11, 2025 01:11
@sebastienros
Copy link
Member

Do we have a plan to automate this somehow

That was the initial plan, but we decided to update this file manually as part of the checklist before shipping. I assume "when" we decide it's worth spending the time on it. There might be some things that are hard to do automatically (multi targeting templates and versions.props, ...)

@danmoseley
Copy link
Member Author

danmoseley commented Feb 12, 2025

chatted offline and @wtgodbe will at least make a script that does something like

“find all *proj in folders like template, look at all , skip all on “allow list of our stuff”, deduplicate, and write out a simple json blob for each” .. and fix a few cases where !!REPLACE_VERSION_HERE!! has to get manually fixed.

that's not necessarily in the build but much better than doing it by hand. and it should be enough for dotnet/sdk as well

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants