[release/9.1] Fix metrics instruments not updating in mobile view #7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Trying to see if the tests will run by closing and reopening. |
|
approved so long as the code reviewers are also comfortable with risk here. |
|
@adamint can you review and assess? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7608 to release/9.1
/cc @JamesNK
Customer Impact
Fix regression from #7549 (oops) where the tree doesn't update in mobile view when changing the resource.
Without this change the mobile view doesn't work correctly for metrics page.
Also, the PR tweaks the padding of the metrics page slightly so the mobile view content matches the new indent of the header which changed in 9.1.
Testing
Manual
Risk
Low
Regression?
Yes