Skip to content

Conversation

radical
Copy link
Member

@radical radical commented Feb 19, 2025

  • Bump timeout for non-helix tests
  • Use blame hang timeout for tests same as used for PRs

@Copilot Copilot AI review requested due to automatic review settings February 19, 2025 00:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/testing/.runsettings: Language not supported

@radical
Copy link
Member Author

radical commented Feb 19, 2025

<!-- Enables blame -->
<DataCollector friendlyName="blame" enabled="True">
<Configuration>
<CollectDumpOnTestSessionHang TestTimeout="7min" HangDumpType="Full" />
Copy link
Member

@danmoseley danmoseley Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about <CollectDump> element (for crashes)?

is "Blame" Logger element also needed?

Just looking at https://learn.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2022#blame-data-collector

@danmoseley danmoseley closed this Feb 19, 2025
@danmoseley danmoseley reopened this Feb 19, 2025
@radical radical merged commit bc07c8a into dotnet:main Feb 19, 2025
70 checks passed
@radical radical deleted the tests-timeout branch February 19, 2025 18:55
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants