-
Notifications
You must be signed in to change notification settings - Fork 695
Add protocol argument to WithEndpoint #7700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
This is a breaking change no? |
These tests assumed that the test environment was always "development" which is no longer the case after dotnet#7700.
Are there any other arguments we should add? This API is frankly a versioning disaster 😄 |
Not sure why Final Results isn't running. Maybe this PR got opened before we made that? I'm going to commit my nit comment to kick off a new CI. |
Description
Adds an optional argument to set the protocol on new endpoints. Currently defaults to tcp with no way to change it but use the overload that take a lamda.
Based on this discussion
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):