Skip to content

Conversation

sebastienros
Copy link
Member

Description

Adds an optional argument to set the protocol on new endpoints. Currently defaults to tcp with no way to change it but use the overload that take a lamda.

Based on this discussion

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings February 20, 2025 00:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@davidfowl
Copy link
Member

This is a breaking change no?

eerhardt added a commit to eerhardt/aspire that referenced this pull request Feb 21, 2025
These tests assumed that the test environment was always "development" which is no longer the case after dotnet#7700.
@eerhardt eerhardt mentioned this pull request Feb 21, 2025
@davidfowl
Copy link
Member

davidfowl commented Feb 24, 2025

Are there any other arguments we should add? This API is frankly a versioning disaster 😄

@eerhardt
Copy link
Member

Not sure why Final Results isn't running. Maybe this PR got opened before we made that? I'm going to commit my nit comment to kick off a new CI.

@davidfowl davidfowl merged commit 75daeb3 into main Feb 28, 2025
71 checks passed
@davidfowl davidfowl deleted the sebros/protocol branch February 28, 2025 00:51
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants