Skip to content

Conversation

danegsta
Copy link
Member

Description

The default Docker CLI available in the pipeline is out of date and causing issues with tests. This PR seeks to update the CLI version used for our test coverage.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings February 20, 2025 19:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • tests/helix/send-to-helix-inner.proj: Language not supported

@radical
Copy link
Member

radical commented Feb 21, 2025

Merge main to get the fix for that codecoverage failure.

@radical
Copy link
Member

radical commented Feb 21, 2025

@radical radical merged commit e64cdd7 into main Feb 22, 2025
75 checks passed
@radical radical deleted the danegsta/dockerVersion branch February 22, 2025 00:07
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants