Skip to content

Re-disable service bug emulator test #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Re-disable service bug emulator test #7775

merged 2 commits into from
Feb 25, 2025

Conversation

adamint
Copy link
Member

@adamint adamint commented Feb 25, 2025

Description

The test has failed at least once since https://github.com/dotnet/aspire/pull/7764/files#diff-92a5f7725129ec797334a76ce547441bfe10ff12af31c37b04d4bc2b9e15e27c was merged earlier today. We should re-disable until #7066 is completed.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@adamint adamint requested review from Copilot, sebastienros and mitchdenny and removed request for Copilot February 25, 2025 20:04
adamint
adamint commented Feb 25, 2025
View reviewed changes
tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs
@@ -179,7 +179,7 @@ public async Task VerifyWaitForOnServiceBusEmulatorBlocksDependentResources()
{
var cts = new CancellationTokenSource(TimeSpan.FromMinutes(10));
using var builder = TestDistributedApplicationBuilder.Create(output);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whitespace was auto-linted. can revert, but it would be better not to have the extra spaces anyway

@eerhardt eerhardt enabled auto-merge (squash) February 25, 2025 20:27
@eerhardt eerhardt merged commit ce4a719 into dotnet:main Feb 25, 2025
71 checks passed
@davidfowl
Copy link
Member

LOL re-disable, I am using this from now on

@Alirexaa
Copy link
Contributor

bug emulator :))

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@sebastienros sebastienros Awaiting requested review from sebastienros

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamint @davidfowl @Alirexaa @eerhardt