Change Redis Insights to use environment variables for preconfigured database connections

[Alirexaa]

Description

This pull request includes significant changes to the Aspire.Hosting.Redis library, focusing on simplifying the WithRedisInsight method, updating the RedisInsight image tag, and improving test coverage. The most important changes are grouped into codebase simplification, image tag updates, and test improvements.

Codebase Simplification:

• src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs: Simplified the WithRedisInsight method by removing the ImportRedisDatabases function and associated logic, and refactoring the environment variable setup for Redis instances.

Image Tag Updates:

• src/Aspire.Hosting.Redis/RedisContainerImageTags.cs: Updated the RedisInsight image tag from 2.66 to 2.68.

Test Improvements:

• tests/Aspire.Hosting.Redis.Tests/AddRedisTests.cs: Added a new test WithRedisInsightProducesCorrectEnvironmentVariables to verify the correct environment variables are set for RedisInsight.
• tests/Aspire.Hosting.Redis.Tests/RedisFunctionalTests.cs: Removed outdated and quarantined tests related to RedisInsight database import and persistence to streamline the test suite. [1] [2] [3]

Fixes #8506
Fixes #7291
Fixes #6099
Fixes #7176

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

[Alirexaa]

@eerhardt, could you import the new Redis Insights tag to netaspireci.azurecr.io? Some tests fail because of that.

[Copilot]

Pull Request Overview

This PR refactors the RedisInsight integration in the Aspire.Hosting.Redis library to simplify the WithRedisInsight method, update the RedisInsight image tag, and improve test coverage by replacing outdated tests with a dedicated test for environment variables.

• Simplified the WithRedisInsight method by removing the ImportRedisDatabases logic and event subscriptions
• Updated the RedisInsight image tag from 2.66 to 2.68
• Enhanced tests with a new test verifying correct environment variable configuration and removed quarantined tests

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
tests/Aspire.Hosting.Redis.Tests/RedisFunctionalTests.cs	Removed quarantined tests to streamline the RedisInsight test suite
tests/Aspire.Hosting.Redis.Tests/AddRedisTests.cs	Added new test to verify RedisInsight environment variable configuration
src/Aspire.Hosting.Redis/RedisContainerImageTags.cs	Updated RedisInsight image tag to 2.68
src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs	Simplified the WithRedisInsight method and refactored environment setup

Comments suppressed due to low confidence (2)

src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs:251

• Ensure that each redis instance's PrimaryEndpoint is allocated before accessing its TargetPort to avoid potential null reference issues. Consider adding a conditional check before adding the environment variable.

context.EnvironmentVariables.Add("RI_REDIS_PORT" + counter, redisInstance.PrimaryEndpoint.TargetPort!.Value);

src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs:244

• [nitpick] If a deterministic order of redisInstances is important for consistent environment variable names, consider sorting the redisInstances collection before iterating.

var counter = 1;

[eerhardt]

@eerhardt, could you import the new Redis Insights tag to netaspireci.azurecr.io? Some tests fail because of that.

Done.

[eerhardt]

This also fixes #7291.

[Alirexaa]

@eerhardt, After this change, the EULA and Privacy Settings dialog will open after every run unless users user WithDataVolume

[eerhardt]

@eerhardt, After this change, the EULA and Privacy Settings dialog will open after every run unless users user WithDataVolume

Yep - that is intentional / by design. It isn't necessarily an "ideal" user experience, but it isn't Aspire's to decision to make. (note the user should be able to make the redis and redis-insights persistent to not have to accept the EULA as well). Check out

• [Feature Request]: Automation in automatic addition of databases redis/RedisInsight#3452 (comment)
• [Bug]: Posting eula: false to /api/settings suppresses the first run dialog redis/RedisInsight#4340

[Alirexaa]

I updated the PR description. This PR fixes four issues. See the description for those.

[eerhardt]

This is great work, @Alirexaa! Thanks for the contribution.

LTGM.