Skip to content

Remove AzureContainerAppEnvironmentResource BicepOutputReferences from public API #8529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

Remove AzureContainerAppEnvironmentResource BicepOutputReferences from public API #8529

merged 1 commit into from
Apr 3, 2025

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 3, 2025

These properties may change over time or be moved in the future. We don't want to expose them just yet. Will expose later if they need to be public.

Contributes to #7811

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@eerhardt
Remove AzureContainerAppEnvironmentResource BicepOutputReferences fro…
7b7b2d4 
…m public API

These properties may change over time or be moved in the future. We don't want to expose them just yet. Will expose later if they need to be public.

Contributes to dotnet#7811
@eerhardt eerhardt requested review from davidfowl and Copilot April 3, 2025 20:39
@eerhardt eerhardt mentioned this pull request Apr 3, 2025
Merged
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 3, 2025
Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@eerhardt
Copy link
Member Author

eerhardt commented Apr 3, 2025

/backport to release/9.2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14252434535

@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Merged
@eerhardt eerhardt merged commit 1121b4b into dotnet:main Apr 3, 2025
175 checks passed
@eerhardt eerhardt deleted the InternalizeContainerAppEnvironmentProps branch April 3, 2025 22:34
@davidfowl davidfowl mentioned this pull request Apr 23, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@mitchdenny mitchdenny mitchdenny approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @mitchdenny