-
Notifications
You must be signed in to change notification settings - Fork 685
Switch to null as default for owner and group in WithContainerFiles #8557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (5)
src/Aspire.Hosting/Dcp/Model/Container.cs:296
- The comment still indicates a default of 0 for root, but the property is now nullable with a default of null. Please update the comment to accurately reflect the new behavior.
// The default owner UID to use for created (or updated) file system entries. Defaults to 0 for root.
src/Aspire.Hosting/Dcp/Model/Container.cs:301
- The comment indicates a default of 0 for root, but since the property type is now nullable, it should be updated to state that the default is null.
// The default group GID to use for created (or updated) file system entries. Defaults to 0 for root.
src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs:773
- Since the parameter now has a null default, the documentation should be updated to indicate that the default value is null rather than 0 for root.
/// <param name="defaultGroup">The default group ID for the created or updated file system. Defaults to 0 for root if not set.</param>
src/Aspire.Hosting/ApplicationModel/ContainerFileSystemCallbackAnnotation.cs:85
- The comment mentions a default of 0 for root while the property is now nullable. Update the comment to reflect the new default, which is null.
/// The UID of the default owner for files/directories to be created or updated in the container. Defaults to 0 for root.
src/Aspire.Hosting/ApplicationModel/ContainerFileSystemCallbackAnnotation.cs:90
- Since the property is now a nullable int with a default of null, the documentation should be updated to remove the reference to a default value of 0 for root.
/// The GID of the default group for files/directories to be created or updated in the container. Defaults to 0 for root.
src/Aspire.Hosting/ApplicationModel/ContainerFileSystemCallbackAnnotation.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one question on the docs.
/backport to release/9.2 |
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14271876544 |
Description
To keep things future proof in case we ever want to change the default behavior, this switches the defaults for defaultOwner and defaultGroup to null instead of 0.
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):