[release/9.2] Obsolete AddAzureContainerAppsInfrastructure (#8639) #8642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Obsolete AddAzureContainerAppsInfrastructure This method is no longer meant to be used. Instead developers should be calling AddAzureContainerAppEnvironment. Covert the tests using this API to the new API * Fix volume output naming issue We weren't discriminating between volumes and bindmounts, which caused a cache collision. * Switch the prefix at the beginning
github-actions
bot
added
the
area-integrations
danmoseley
added
Servicing-approved
davidfowl
approved these changes
Apr 8, 2025
|
@danmoseley @joperezr @mitchdenny - I need 1 more reviewer to sign off here. I can't myself since I had to open the PR not using the backport bot since there were merge conflicts. |
danmoseley
approved these changes
Apr 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8639 to release/9.2
/cc @eerhardt
Customer Impact
We don't want users calling AddAzureContainerAppsInfrastructure anymore. They should be using AddAzureContainerAppEnvironment instead. The reason we want to push them to AddAzureContainerAppEnvironment is so we aren't "half in"
azdinfrastructure and half Aspire infrastructure.There was also a bug exposed with tests in how we were naming volumes. Found by switching our tests from AddAzureContainerAppsInfrastructure to AddAzureContainerAppEnvironment.
Testing
Existing tests
Risk
Low
Regression?
No