Skip to content

Fix outerloop issues #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix outerloop issues #8687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54dc22e
Fix outerloop issues
RussKie Apr 10, 2025
147f5a0
Update .github/workflows/tests-outerloop.yml
RussKie Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests-outerloop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
if: always()
shell: pwsh
run: |
$logDirectory = "${{ github.workspace }}/artifacts/log/**/TestLogs"
$logDirectory = "${{ github.workspace }}/artifacts/TestResults"
$trxFiles = Get-ChildItem -Path $logDirectory -Filter *.trx -Recurse

$testResults = @() # Initialize an array to store test results
Expand Down Expand Up @@ -172,4 +172,5 @@ jobs:
path: |
${{ github.workspace }}/artifacts/log/*/*.binlog
${{ github.workspace }}/artifacts/log/*/TestLogs/**
${{ github.workspace }}/artifacts/TestResults/*/*.trx
retention-days: 5
3 changes: 2 additions & 1 deletion eng/Testing.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
<SkipTests>true</SkipTests>

<!-- Only run tests if the build is running on GitHub Actions -->
<SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(RunOnGithubActions)' == 'true' ">false</SkipTests>
<SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(BuildOs)' == 'windows' and '$(RunOnGithubActionsWindows)' == 'true' ">false</SkipTests>
<SkipTests Condition=" '$(IsGitHubActionsRunner)' == 'true' and '$(BuildOs)' != 'windows' and '$(RunOnGithubActionsLinux)' == 'true' ">false</SkipTests>

<!-- Only run tests if the build is running on Helix infra -->
<SkipTests Condition=" '$(IsAzdoHelixRunner)' == 'true' and '$(RunOnAzdoHelix)' == 'true' ">false</SkipTests>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue affects only the GHA, I don't want to upset and break the AzDO builds (I tried changing the other properties, and that led to failed build in AzDO).
We can look at the AzDO separation later.

Expand Down
8 changes: 8 additions & 0 deletions tests/Aspire.Components.Common.Tests/Aspire.Components.Common.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

<PropertyGroup>
<TargetFramework>$(DefaultTargetFramework)</TargetFramework>

<!--
Whilst this looks like a test project, it is not... https://github.com/dotnet/aspire/pull/8498/files#r2029349258
-->
<IsTestUtilityProject>true</IsTestUtilityProject>
<SkipTests>true</SkipTests>
<DeployOutsideOfRepoSupportFiles>false</DeployOutsideOfRepoSupportFiles>

<!-- https://learn.microsoft.com/dotnet/core/testing/microsoft-testing-platform-exit-codes -->
<!-- Exit code 8 is "zero tests ran" -->
<!-- Currently, none of the tests in this project run in CI. All are ignored -->
Expand Down