Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 19, 2025

Support for showing uninstrumented outgoing peers in traces page. A fair number of changes were required here because resources are scoped to a browser window (was required because browser language and time was used in some places) while telemetry is static.

  • Telemetry changes
    • Resolving uninstrumented peers now happens during data load
    • Peers are re-resolved when resources change
    • Telemetry application is created for uninstrumented peers
    • Traces UI displays peer apps in filter dropdown
    • Traces UI displays peer apps in span summary
  • Resource data changes
    • Resource change event for peers now only happens when the resource URLs change, rather than on every change. Perf improvement to prevent it triggering on every status change
    • Dashboard resource client is now a singleton. Done so it can be used from telemetry repository (already singleton) but has the benefit of sharing data if you have multiple browser windows open
    • Dashboard properties has a new display VM. This is so that scoped data (e.g. culture, time) is only applied on display. This change allows resource client to be a singleton

Peers displayed in traces UI:
image

Filtering to a peer:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK merged commit 35d7c6d into main Apr 22, 2025
174 checks passed
@JamesNK JamesNK deleted the jamesnk/tracing-outgoing-peers branch April 22, 2025 03:40
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants