[release/9.2] Ensure visible trace spans stay sorted by start time and fix Traces view expand/collapse icons #8909
+233
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
area-dashboard
Servicing-consider
There was a problem hiding this comment.
Pull Request Overview
This pull request backports a fix to ensure that visible trace spans are sorted by start time and resolves an issue with the expand/collapse icons in the Traces view.
- Added tests to validate the correct ordering of spans and toggle behavior for span collapse/expand.
- Updated the TraceDetail component to filter out hidden spans and accurately compute the total item count.
- Enhanced the Stress playground applications with new HTTP commands and OpenTelemetry sources to simulate nested trace spans.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Aspire.Dashboard.Components.Tests/Pages/TraceDetailsTests.cs | Added tests for span ordering and collapse toggle behavior |
| src/Aspire.Dashboard/Components/Pages/TraceDetail.razor.cs | Updated GetData filtering logic and added a refresh data call after collapse toggle |
| playground/Stress/Stress.AppHost/Program.cs | Added a new HTTP command for simulating out-of-order nested spans |
| playground/Stress/Stress.ApiService/Program.cs | Added OpenTelemetry enhancements and a new endpoint for nested trace spans |
JamesNK
changed the title
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Apr 22, 2025
joperezr
approved these changes
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8771
Customer Impact
Spans can be displayed out of order, creating a confusing experience when viewing the traces.
Also, collapsing spans isn't working, preventing users from collapsing spans to focus on certain data in the trace view.
Testing
A unit test has been added and a diff is included in the original PR if manual testing is desired as well.
Manual test before:
Manual test after:
Risk
This is a small, isolated, tested change where the root cause is well understood.
Regression?
Yes