Add tracing support for Azure App Configuration component #9323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
radical,
eerhardt and
sebastienros
as code owners
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-integrations
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the Azure App Configuration package to version 8.2.0 and adds OpenTelemetry tracing support along with the corresponding configuration and tests.
- Updated JSON configuration schema and tests to include the new "DisableTracing" property.
- Implemented tracing enablement/disablement logic in component settings and extension methods.
- Updated package references to the new version.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests/ConformanceTests.cs | Added "DisableTracing" configuration property handling and implemented tracing method logic. |
| tests/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests/ConfigurationTests.cs | Added unit test to validate the default tracing behavior. |
| src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/ConfigurationSchema.json | Updated schema to include the new "DisableTracing" property with description and default value. |
| src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationSettings.cs | Added the "DisableTracing" property with documentation. |
| src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/AspireAppConfigurationExtensions.cs | Modified extension method to conditionally add tracing support based on the new property. |
| Directory.Packages.props | Upgraded package versions to 8.2.0. |
tests/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration.Tests/ConformanceTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
May 15, 2025
| => throw new NotImplementedException(); | ||
| { | ||
| // wait for 1 seconds to ensure the refresh interval is exceeded | ||
| Task.Delay(1000).ConfigureAwait(false).GetAwaiter().GetResult(); |
There was a problem hiding this comment.
Is there a better way to do this? Is there a way to "force" the refresh?
There was a problem hiding this comment.
We used to have a "force" refresh api. But for some reason, we removed it. In our own testsuite, we also used "waiting for some time" way to test refresh. example
eerhardt
approved these changes
May 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded
Microsoft.Extensions.Configuration.AzureAppConfigurationto 8.2.0.Added tracing support for Azure App Configuration component.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate