Skip to content

Conversation

radical
Copy link
Member

@radical radical commented May 20, 2025

Prompted by:

/home/runner/work/aspire/aspire/eng/Versions.targets(49,67): error MSB4057: The target "GitInfo" does not exist in the project. [/home/runner/work/aspire/aspire/src/Aspire.AppHost.Sdk/Aspire.RuntimeIdentifier.Tool/Aspire.RuntimeIdentifier.Tool.csproj]

Prompted by:
```
/home/runner/work/aspire/aspire/eng/Versions.targets(49,67): error MSB4057: The target "GitInfo" does not exist in the project. [/home/runner/work/aspire/aspire/src/Aspire.AppHost.Sdk/Aspire.RuntimeIdentifier.Tool/Aspire.RuntimeIdentifier.Tool.csproj]
```
@Copilot Copilot AI review requested due to automatic review settings May 20, 2025 04:44
@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label May 20, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue encountered during the build process where the "GitInfo" target was missing by modifying the CI environment variable setup in the GitHub workflow.

  • Added an env block to set CI to false before building the solution.
  • Prevents GitInfo errors during the build.
Comments suppressed due to low confidence (1)

.github/workflows/copilot-setup-steps.yml:21

  • [nitpick] Setting CI to false in this step helps avoid GitInfo errors, but consider verifying that this change doesn't inadvertently affect other CI-dependent operations. If possible, limit the scope of this override to only the necessary command.
env:

@mitchdenny
Copy link
Member

When I ran ./build.sh in codespaces with prepareforhelix true but left CI as default value it worked, so I think this change will work for whatever environment Copilot creates for itself.

@radical
Copy link
Member Author

radical commented May 20, 2025

@radical
Copy link
Member Author

radical commented May 20, 2025

Merging without waiting for the tests workflow because this change only affects the copilot setup steps.

@radical radical merged commit 5c4f9f5 into dotnet:main May 20, 2025
252 of 253 checks passed
@radical radical deleted the fix-copilot-main branch May 20, 2025 04:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants