-
Notifications
You must be signed in to change notification settings - Fork 686
Fix malformed table output in aspire run command when no resources are present #9498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c448f3
Initial plan for issue
Copilot 7b5a5df
Fix for malformed table output in aspire run command
Copilot 9b1cf6c
Tweak presentation of no resources.
mitchdenny 76240b7
Make placeholder row creation dynamic based on column count
Copilot f8720b2
PR feedback from David.
mitchdenny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace Aspire.Cli.Tests.Utils; | ||
|
||
/// <summary> | ||
/// A utility class that provides an empty IAsyncEnumerable<T>. | ||
/// </summary> | ||
/// <typeparam name="T">The type of the elements in the empty enumerable.</typeparam> | ||
internal sealed class EmptyAsyncEnumerable<T> | ||
{ | ||
/// <summary> | ||
/// Gets a singleton instance of an empty <see cref="IAsyncEnumerable{T}"/>. | ||
/// </summary> | ||
public static readonly IAsyncEnumerable<T> Instance = new EmptyAsyncEnumerableImpl(); | ||
|
||
private sealed class EmptyAsyncEnumerableImpl : IAsyncEnumerable<T> | ||
{ | ||
public IAsyncEnumerator<T> GetAsyncEnumerator(CancellationToken cancellationToken = default) | ||
{ | ||
return new EmptyAsyncEnumerator(); | ||
} | ||
|
||
private sealed class EmptyAsyncEnumerator : IAsyncEnumerator<T> | ||
{ | ||
public T Current => default!; | ||
|
||
public ValueTask DisposeAsync() => ValueTask.CompletedTask; | ||
|
||
public ValueTask<bool> MoveNextAsync() => new ValueTask<bool>(Task.FromResult(false)); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot You don't need this class, there's a built in
AsyncEnumerable.Empty<T>()