-
Notifications
You must be signed in to change notification settings - Fork 695
Expose the NameOutputReference property on AzureResources #9501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
4f871a2
b8f5001
8a7ee32
3e475ba
7349481
87dbb41
ed42c0a
73ac86b
f0fdbaa
1438ad7
b3cde5b
252418c
70f15e7
ec2e835
c490a30
bc9983d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,11 @@ public class AzureRedisResource(RedisResource innerResource, Action<AzureResourc | |
{ | ||
private readonly RedisResource _innerResource = innerResource ?? throw new ArgumentNullException(nameof(innerResource)); | ||
|
||
/// <summary> | ||
/// Gets the "name" output reference for the resource. | ||
/// </summary> | ||
public BicepOutputReference NameOutputReference => new("name", this); | ||
|
||
|
||
/// <summary> | ||
/// Gets the "connectionString" output reference from the bicep template for the Azure Redis resource. | ||
/// </summary> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,10 @@ public class AzureSignalRResource(string name, Action<AzureResourceInfrastructur | |
/// </summary> | ||
public BicepOutputReference HostName => new("hostName", this); | ||
|
||
private BicepOutputReference NameOutputReference => new("name", this); | ||
/// <summary> | ||
/// Gets the "name" output reference for the resource. | ||
/// </summary> | ||
public BicepOutputReference NameOutputReference => new("name", this); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] The Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
/// <summary> | ||
/// Gets the connection string template for the manifest for Azure SignalR. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,11 @@ namespace Aspire.Hosting.Azure; | |
public sealed class AzureUserAssignedIdentityResource(string name) | ||
: AzureProvisioningResource(name, ConfigureAppIdentityInfrastructure), IAppIdentityResource | ||
{ | ||
/// <summary> | ||
/// Gets the "name" output reference for the resource. | ||
/// </summary> | ||
public BicepOutputReference NameOutputReference => new("name", this); | ||
|
||
|
||
/// <summary> | ||
/// The identifier associated with the user assigned identity. | ||
/// </summary> | ||
|
@@ -55,6 +60,7 @@ private static void ConfigureAppIdentityInfrastructure(AzureResourceInfrastructu | |
infrastructure.Add(new ProvisioningOutput("clientId", typeof(string)) { Value = userAssignedIdentity.ClientId }); | ||
infrastructure.Add(new ProvisioningOutput("principalId", typeof(string)) { Value = userAssignedIdentity.PrincipalId }); | ||
infrastructure.Add(new ProvisioningOutput("principalName", typeof(string)) { Value = userAssignedIdentity.Name }); | ||
infrastructure.Add(new ProvisioningOutput("name", typeof(string)) { Value = userAssignedIdentity.Name }); | ||
} | ||
|
||
/// <inheritdoc/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this. The resource is obsolete. Plus nothing is not outputting the name in the bicep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the
NameOutputReference
property from AzurePostgresResource as it's obsolete and doesn't output the name in bicep. Fixed in commit c490a30.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.