Fix gRPC template tests #45702
Merged
Fix gRPC template tests #45702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
JamesNK
force-pushed
the
jamesnk/grpctemplatetests-arm64
branch
from
8dcad96 to
c231d26
Compare
5 tasks
JamesNK
force-pushed
the
jamesnk/grpctemplatetests-arm64
branch
from
c231d26 to
8a80a1b
Compare
dougbu
reviewed
Jan 3, 2023
BrennanConroy
approved these changes
Jan 4, 2023
| @@ -35,7 +35,7 @@ public ITestOutputHelper Output | |||
| } | |||
|
|
|||
| [ConditionalTheory] | |||
| [SkipOnHelix("Not supported queues", Queues = "All.OSX;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)] | |||
| [SkipOnHelix("Not supported queues", Queues = "windows.11.arm64.open;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)] | |||
There was a problem hiding this comment.
Can we add this value to HelixConstants?
There was a problem hiding this comment.
Probably. But first, I'd like to ensure this change fixes the problem. The problem is that the Helix queue only runs on full CI (i.e. not PR CI). Need to merge to check.
There was a problem hiding this comment.
There are ways to run it without merging PRs, oh well
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #41716
Grpc.Tools (aka protoc.exe) doesn't support Windows ARM 64. Don't run gRPC templates on
windows.11.arm64.open.Also ensures gRPC template tests run on macOS.