-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/9.0] Fix handling for inert route parameters in MVC endpoints for OpenAPI #58311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcasey
approved these changes
Oct 9, 2024
Approved via email. |
This was referenced Jul 22, 2025
Closed
chore: Bump Microsoft.AspNetCore.Components.WebAssembly.DevServer and 6 others
Markinatorina/MSAVA#7
Merged
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Sep 2, 2025
Closed
Bump Microsoft.Extensions.Caching.StackExchangeRedis from 6.0.36 to 9.0.9
bcgov/emcr-dfa-portal#1008
Open
This was referenced Sep 9, 2025
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-mvc
Includes: MVC, Actions and Controllers, Localization, CORS, most templates
feature-openapi
Servicing-approved
Shiproom has approved the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #58246 to release/9.0.
This PR makes the OpenAPI implementation more resilient to "inert route parameters" in MVC. Inert route parameters appear in the route template but are never bound to in the route handler. For example:
This pattern happens frequently when users integrate with the API versioning package which uses inert route parameters to distinguish between different versions of an API.
Fixes #58219
Customer Impact
Without this PR, customers are not able to generate OpenAPI specs for APIs that are versioning with the API versioning package and use version numbers in the URL.
There are no workarounds for this issue.
Regression?
Risk
Change is localized to OpenAPI package and makes the package more resilient to bad inputs.
Verification
Packaging changes reviewed?