Skip to content

Update HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract #58558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract #58558

merged 1 commit into from
Oct 22, 2024

Conversation

MackinnonBuck
Copy link
Member

Fixes an issue where HtmlAttributePropertyHelper did not correctly follow the MetadataUpdateHandlerAttribute contract, causing hot reload to fail.

Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3202

@MackinnonBuck MackinnonBuck added feature-hot-reload This issue is related to the Hot Reload feaature area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages labels Oct 21, 2024
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 21, 2024 22:54
@MackinnonBuck MackinnonBuck requested a review from a team October 21, 2024 22:55
@MackinnonBuck MackinnonBuck changed the title Updated HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract Update HtmlAttributePropertyHelper to correctly follow the MetadataUpdateHandlerAttribute contract Oct 21, 2024
@MackinnonBuck MackinnonBuck merged commit 5f156a2 into main Oct 22, 2024
27 checks passed
@MackinnonBuck MackinnonBuck deleted the mbuck/fix-htmlattributepropertyhelper branch October 22, 2024 18:50
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 22, 2024
@gkinsman
Copy link

gkinsman commented Dec 11, 2024 •
edited
Loading

Hi there, this appears to cause a ~5s delay for hot reload in blazor apps with this error:

dotnet watch ⚠ [XXX (net9.0)] Expected to find a static method 'ClearCache' or 'UpdateApplication' on type 'Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlAttributePropertyHelper, Microsoft.AspNetCore.Mvc.ViewFeatures, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' but neither exists.

I see this has been tagged with .NET 10 - does this mean this will cause a slowdown until its release?

Thanks!

@tmat tmat mentioned this pull request Jan 16, 2025
Closed
@MackinnonBuck
Copy link
Member Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12818185244

@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Merged
10 tasks
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@MackinnonBuck @captainsafia
Fix HtmlAttributePropertyHelper hot reload (#58558)
bd86c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn approved these changes

Assignees
No one assigned
Labels
area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages feature-hot-reload This issue is related to the Hot Reload feaature
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@MackinnonBuck @gkinsman @javiercn