Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open #59112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
halter73,
BrennanConroy,
JamesNK and
mgravell
as code owners
ghost
added
the
area-networking
|
Huh, maybe skip attributes on abstract classes aren't discovered This is what we should do in both WebSocketsOutOfProcess and WebSocketsInProcess then. |
|
WebSocketsInProcess too |
I didn't spot any failures in the in-process tests. Do we want to update the annotation as a proactive measure since they use the same base class? |
|
The screenshot I shared in #59112 (comment) shows in process failing as well. It was from the latest Helix run. |
BrennanConroy
approved these changes
Nov 22, 2024
wtgodbe
pushed a commit
that referenced
this pull request
Nov 27, 2024
…ndshake (#58931) * Fix IIS outofprocess to remove WebSocket compression handshake * test name * Don't run IIS websocket tests on unsupported queue * comment * using * using * not * Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open (#59112) * Skip WebSocketOutOfProcessTests on Windows.Amd64.Server2022.Open * Use if-def from base class * Fix in-proc and remove attributes from abstract class --------- Co-authored-by: Brennan <[email protected]> Co-authored-by: Safia Abdalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #59111.